lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 12:15:57 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com> Subject: [PATCH 4.19 204/280] device property: Fix the length used in PROPERTY_ENTRY_STRING() 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Heikki Krogerus <heikki.krogerus@...ux.intel.com> commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream. With string type property entries we need to use sizeof(const char *) instead of the number of characters as the length of the entry. If the string was shorter then sizeof(const char *), attempts to read it would have failed with -EOVERFLOW. The problem has been hidden because all build-in string properties have had a string longer then 8 characters until now. Fixes: a85f42047533 ("device property: helper macros for property entry creation") Cc: 4.5+ <stable@...r.kernel.org> # 4.5+ Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- include/linux/property.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/property.h +++ b/include/linux/property.h @@ -258,7 +258,7 @@ struct property_entry { #define PROPERTY_ENTRY_STRING(_name_, _val_) \ (struct property_entry) { \ .name = _name_, \ - .length = sizeof(_val_), \ + .length = sizeof(const char *), \ .type = DEV_PROP_STRING, \ { .value = { .str = _val_ } }, \ }
Powered by blists - more mailing lists