lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 22 Mar 2019 12:13:56 +0100
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, Gilad Ben-Yossef <>,
        Herbert Xu <>
Subject: [PATCH 5.0 017/238] crypto: ccree - unmap buffer before copying IV

5.0-stable review patch.  If anyone has any objections, please let me know.


From: Gilad Ben-Yossef <>

commit c139c72e2beb3e3db5148910b3962b7322e24374 upstream.

We were copying the last ciphertext block into the IV field
for CBC before removing the DMA mapping of the output buffer
with the result of the buffer sometime being out-of-sync cache
wise and were getting intermittent cases of bad output IV.

Fix it by moving the DMA buffer unmapping before the copy.

Signed-off-by: Gilad Ben-Yossef <>
Fixes: 00904aa0cd59 ("crypto: ccree - fix iv handling")
Cc: <>
Signed-off-by: Herbert Xu <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/crypto/ccree/cc_cipher.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/crypto/ccree/cc_cipher.c
+++ b/drivers/crypto/ccree/cc_cipher.c
@@ -653,6 +653,8 @@ static void cc_cipher_complete(struct de
 	unsigned int ivsize = crypto_skcipher_ivsize(sk_tfm);
 	unsigned int len;
+	cc_unmap_cipher_request(dev, req_ctx, ivsize, src, dst);
 	switch (ctx_p->cipher_mode) {
@@ -682,7 +684,6 @@ static void cc_cipher_complete(struct de
-	cc_unmap_cipher_request(dev, req_ctx, ivsize, src, dst);
 	skcipher_request_complete(req, err);

Powered by blists - more mailing lists