lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 22 Mar 2019 20:43:31 +0800
From:   Herbert Xu <>
To:     Joe Perches <>
Cc:     "David S. Miller" <>,, LKML <>
Subject: Re: [possible PATCH] crypto: sahara - Use #ifdef DEBUG not

On Thu, Mar 07, 2019 at 04:15:55PM -0800, Joe Perches wrote:
> Normal use of IS_ENABLED is with a CONFIG_<SYMBOL> and
> there is no -DDEBUG in the Makefile here.
> Replace the IS_ENABLED(DEBUG) with #ifdef DEBUG/#endif
> blocks.
> Miscellanea:
> o Move the sahara_state array into the function that uses it.
> Signed-off-by: Joe Perches <>
> ---
>  drivers/crypto/sahara.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)

Even if this is correct this is way too ugly.  The original code
at least compiled everything regardless of macros.  Your new code
won't detect compile errors in debugging code unless debugging is

Email: Herbert Xu <>
Home Page:
PGP Key:

Powered by blists - more mailing lists