lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 12:13:38 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Sven Van Asbroeck <thesven73@...il.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Sven Van Asbroeck <TheSven73@...il.com>, Robin van der Gracht <robin@...tonic.nl>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Sasha Levin <sashal@...nel.org> Subject: [PATCH 4.19 065/280] auxdisplay: ht16k33: fix potential user-after-free on module unload 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 69ef9bc54715fb1cb7786ada15774e469e822209 ] On module unload/remove, we need to ensure that work does not run after we have freed resources. Concretely, cancel_delayed_work() may return while the callback function is still running. >>From kernel/workqueue.c: The work callback function may still be running on return, unless it returns true and the work doesn't re-arm itself. Explicitly flush or use cancel_delayed_work_sync() to wait on it. Link: https://lore.kernel.org/lkml/20190204220952.30761-1-TheSven73@googlemail.com/ Reported-by: Sven Van Asbroeck <thesven73@...il.com> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com> Reviewed-by: Sven Van Asbroeck <TheSven73@...il.com> Acked-by: Robin van der Gracht <robin@...tonic.nl> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> Signed-off-by: Sasha Levin <sashal@...nel.org> --- drivers/auxdisplay/ht16k33.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index a43276c76fc6..21393ec3b9a4 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -509,7 +509,7 @@ static int ht16k33_remove(struct i2c_client *client) struct ht16k33_priv *priv = i2c_get_clientdata(client); struct ht16k33_fbdev *fbdev = &priv->fbdev; - cancel_delayed_work(&fbdev->work); + cancel_delayed_work_sync(&fbdev->work); unregister_framebuffer(fbdev->info); framebuffer_release(fbdev->info); free_page((unsigned long) fbdev->buffer); -- 2.19.1
Powered by blists - more mailing lists