lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 21:04:16 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Arnd Bergmann <arnd@...db.de> Cc: Gilad Ben-Yossef <gilad@...yossef.com>, "David S. Miller" <davem@...emloft.net>, Eric Biggers <ebiggers@...gle.com>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] crypto: ccree - reduce kernel stack usage with clang On Thu, Mar 14, 2019 at 10:09:44AM +0100, Arnd Bergmann wrote: > Building with clang for a 32-bit architecture runs over the stack > frame limit in the setkey function: > > drivers/crypto/ccree/cc_cipher.c:318:12: error: stack frame size of 1152 bytes in function 'cc_cipher_setkey' [-Werror,-Wframe-larger-than=] > > The problem is that there are two large variables: the temporary > 'tmp' array and the SHASH_DESC_ON_STACK() declaration. Moving > the first into the block in which it is used reduces the > total frame size to 768 bytes, which seems more reasonable > and is under the warning limit. > > Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > drivers/crypto/ccree/cc_cipher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists