linux-kernel - Re: regression (bisected): "modprobe parport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1572645.oXzt2vILsi@alaris>
Date:   Fri, 22 Mar 2019 07:13:23 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

On Thursday, 21 March 2019 23:43 Sudip Mukherjee wrote:
> HI Michal,
> 
> On Wed, Mar 20, 2019 at 9:18 PM Michal Kubecek <mkubecek@...e.cz> wrote:
> > On Wed, Mar 20, 2019 at 09:30:59AM +0000, Sudip Mukherjee wrote:
> > > Sorry, I didn't get the chance to look at it yet and have kept it
> > > pending for this weekend. But just had a quick look and I was
> > > wondering if the machine on which you are trying the modprobe has
> > > an
> > > actual parallel port or the machine is not having any parallel
> > > port.
> > > And also will you be able to send me a dmesg please.
> > 
> > Attaching dmesg output from a virtual machine which doesn't seem to
> > have a (virtual) parallel port. This part:
> > 
> > [   63.962283] parport_pc 00:05: reported by Plug and Play ACPI
> > [   63.962469] parport0: PC-style at 0x378, irq 7 [PCSPP,TRISTATE]
> > [   64.061723] ppdev: user-space parallel port driver
> > 
> > was after I manually killed "/sbin/modprobe -q -- parport_lowlevel"
> > which was started during boot.
> 
> Thanks for testing. I am unable to reproduce the problem in VM or in
> machine, with or without parallel port. But from your logs it looks
> like you have an alias set for "parport_lowlevel". When parport module
> is being loaded if it does not find any port in its list, it will try
> to load "parport_lowlevel" and that is where you are getting the
> deadlock. "parport_lowlevel" is not a real module, but instead should
> be an alias pointing to some real module. I tried by setting an alias
> of parport_lowlevel" as parport_pc but still could not get the
> problem.
> Can you please check in your VM or machine what do you have the alias
> as? It should be either in "/etc/modprobe.conf" or some conf file in
> "/etc/modprobe.d" folder.

You are right, this is in /etc/modprobe.d/00-system which is part of
suse-module-tools package:

-----------------------------------------------------------------------
alias parport_lowlevel    parport_pc
# disable DMA for parallel port (bnc#180390)
# Please note, the dma= and irq= options require that the io= option also be
# specified.
options parport_pc dma=none
# options parport_pc io=0x378 irq=none
# If you have multiple parallel ports, specify them this way:
# options parport_pc io=0x378,0x278  irq=none,none
-----------------------------------------------------------------------

"bnc#180390" means https://bugzilla.suse.com/show_bug.cgi?id=180390

There is a git repository for suse-module-tools package on github but
unfortunately it starts in 2017 and as comment 98 in the bug above
shows that the alias line was already in place in 2008, the reason
won't be found in OBS history either.

Anyway, when I comment out the alias line, "modprobe parport_pc"
succeeds immediately and loads parport, parport_pc and ppdev.

> And also, will you be able to test a debug patch on your VM?

Yes, definitely.

Michal