lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 15:20:28 +0100 From: Arnd Bergmann <arnd@...db.de> To: Nathan Chancellor <natechancellor@...il.com> Cc: Andy Gross <andy.gross@...aro.org>, David Brown <david.brown@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-arm-msm@...r.kernel.org, linux-serial@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, clang-built-linux@...glegroups.com Subject: Re: [PATCH] tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup On Fri, Mar 8, 2019 at 7:38 PM Nathan Chancellor <natechancellor@...il.com> wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: variable 'baud' > is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > It's not wrong; when options is NULL, baud has no default value. Use > 9600 as that is a sane default. > > Link: https://github.com/ClangBuiltLinux/linux/issues/395 > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Signed-off-by: Nathan Chancellor <natechancellor@...il.com> > --- > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3bcec1c20219..35e5f9c5d5be 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -1050,7 +1050,7 @@ static int __init qcom_geni_console_setup(struct console *co, char *options) > { > struct uart_port *uport; > struct qcom_geni_serial_port *port; > - int baud; > + int baud = 9600; > int bits = 8; > int parity = 'n'; > int flow = 'n'; I made a similar patch here, but after looking at the driver concluded that the bitrate had to be 115200, since that is used as the default value otherwise. Arnd
Powered by blists - more mailing lists