[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190322150009.GY6058@hirez.programming.kicks-ass.net>
Date: Fri, 22 Mar 2019 16:00:09 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: x86 <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
Len Brown <len.brown@...el.com>,
Linux PM <linux-pm@...r.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Laura Abbott <labbott@...oraproject.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...nel.org>,
Simon Schricker <sschricker@...e.de>,
Borislav Petkov <bp@...e.de>, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH 2/2] PM / arch: x86: MSR_IA32_ENERGY_PERF_BIAS sysfs
interface
On Thu, Mar 21, 2019 at 11:20:17PM +0100, Rafael J. Wysocki wrote:
> + ret = rdmsrl_on_cpu(cpu, MSR_IA32_ENERGY_PERF_BIAS, &epb);
> + if (ret < 0)
> + return ret;
> +
> + ret = wrmsrl_on_cpu(cpu, MSR_IA32_ENERGY_PERF_BIAS,
> + (epb & ~EPB_MASK) | val);
That's two back-to-back IPIs and a giant waste.
If you'd use a proper msr shadow variable, you'd not have to do the
rdmsr_on_cpu :-)
Powered by blists - more mailing lists