lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 18:16:45 +0300 From: Kirill Tkhai <ktkhai@...tuozzo.com> To: Chris Down <chris@...isdown.name>, Andrew Morton <akpm@...ux-foundation.org> Cc: Johannes Weiner <hannes@...xchg.org>, Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, linux-mm@...ck.org, kernel-team@...com Subject: Re: [PATCH] fixup: vmscan: Fix build on !CONFIG_MEMCG from nr_deactivate changes On 22.03.2019 18:05, Chris Down wrote: > "mm: move nr_deactivate accounting to shrink_active_list()" uses the > non-irqsaved version of count_memcg_events (__count_memcg_events), but > we've only exported the irqsaving version of it to userspace, so the > build breaks: > > mm/vmscan.c: In function ‘shrink_active_list’: > mm/vmscan.c:2101:2: error: implicit declaration of function ‘__count_memcg_events’; did you mean ‘count_memcg_events’? [-Werror=implicit-function-declaration] > > This fixup makes it build with !CONFIG_MEMCG. Yeah, thanks, Chris. > Signed-off-by: Chris Down <chris@...isdown.name> > Cc: Andrew Morton <akpm@...ux-foundation.org> > Cc: Kirill Tkhai <ktkhai@...tuozzo.com> > Cc: Johannes Weiner <hannes@...xchg.org> > Cc: Tejun Heo <tj@...nel.org> > Cc: linux-kernel@...r.kernel.org > Cc: cgroups@...r.kernel.org > Cc: linux-mm@...ck.org > Cc: kernel-team@...com > --- > include/linux/memcontrol.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 534267947664..b226c4bafc93 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1147,6 +1147,12 @@ static inline void count_memcg_events(struct mem_cgroup *memcg, > { > } > > +static inline void __count_memcg_events(struct mem_cgroup *memcg, > + enum vm_event_item idx, > + unsigned long count) > +{ > +} > + > static inline void count_memcg_page_event(struct page *page, > int idx) > { >
Powered by blists - more mailing lists