linux-kernel - Re: [RFC PATCH 1/3] arch/x86: add ACRN hypervisor guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1903221615500.1729@nanos.tec.linutronix.de>
Date:   Fri, 22 Mar 2019 16:20:09 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Zhao Yakui <yakui.zhao@...el.com>
cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        Jason Chen CJ <jason.cj.chen@...el.com>
Subject: Re: [RFC PATCH 1/3] arch/x86: add ACRN hypervisor guest

Zhao,

On Thu, 7 Mar 2019, Zhao Yakui wrote:

> ACRN is one open-source hypervisour, which is maintained by Linux
> foundation. This is to add the para-virtualization support so that
> it allows to enable the Linux guest on acrn-hypervisor.
> 
> This adds x86_hyper_acrn into supported hypervisors array, which
> enables ACRN services guest running on ACRN hypervisor. It is

What is a ACRN services guest? 

> restricted to X86_64.
> 
> Signed-off-by: Jason Chen CJ <jason.cj.chen@...el.com>
> Signed-off-by: Zhao Yakui <yakui.zhao@...el.com>

This SOB chain is wrong. If Jason wrote the patch, then there should be a
'From: Jason ..' line at the top of the change log. If you both wrote it
then Jason's SOB wants to be preceeded by a 'Co-developed-by: Jason....'
line. See Documentation/process/

> +config ACRN
> +	bool "Enable services on ACRN hypervisor"
> +	depends on X86_64 && PARAVIRT
> +	help
> +	  This option allows to run Linux as guest in ACRN hypervisor.
> +	  It is needed if you want to run ACRN services linux on top of
> +	  ACRN hypervisor.

This help text does not make any sense to me.

> +const struct hypervisor_x86 x86_hyper_acrn = {
> +	.name                   = "ACRN",
> +	.detect                 = acrn_detect,
> +	.type			= X86_HYPER_ACRN,
> +	.init.init_platform     = acrn_init_platform,
> +	.init.x2apic_available  = acrn_x2apic_available,
> +};
> +EXPORT_SYMBOL(x86_hyper_acrn);

Whay is this exported? The only user of this is hypervisor.c and that is
built in. Please remove.

Thanks,

	tglx