linux-kernel - Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b356f99c-15ff-06ce-e40b-4bb8b664b6c9@linaro.org>
Date:   Fri, 22 Mar 2019 15:23:48 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Gaurav Kohli <gkohli@...eaurora.org>, linux-kernel@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org,
        Shiraz Hashim <shashim@...eaurora.org>
Subject: Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace



On 20/03/2019 05:53, Gaurav Kohli wrote:
> From: Shiraz Hashim <shashim@...eaurora.org>
> 
> Existing nvmem framework export full register space
> as nvmem binary, but not exporting child node of nvmem
> which is nvmem cell. Kernel can read the specific cell
> by using nvmem_cell_read but userspace don't have such
> provision.
> 
> Add framework to export nvmem cell as well, So
> userspace can use it directly.
> 
> Signed-off-by: Shiraz Hashim <shashim@...eaurora.org>
> Signed-off-by: Gaurav Kohli <gkohli@...eaurora.org>
> Co-developed-by: Gaurav Kohli <gkohli@...eaurora.org>
> 
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c

Thankyou for the patch.

Why do you need such provision when the userspace can just get the cell 
values using correct offset and size.
This will also bring over head of managing entries dynamically + 
confusing userspace abi.

Unless you have a valid reason or usecase I don't see the need for this.

thanks,
srini