linux-kernel - [PATCH v4 11/11] selftests/ftrace: Change stderr redirection for probe error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ce51abd8585b775fd98e31e5feb1b1505483312f.1553268041.git.tom.zanussi@linux.intel.com>
Date:   Fri, 22 Mar 2019 10:34:37 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     rostedt@...dmis.org
Cc:     tglx@...utronix.de, mhiramat@...nel.org, namhyung@...nel.org,
        bigeasy@...utronix.de, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: [PATCH v4 11/11] selftests/ftrace: Change stderr redirection for probe error_log testcase

From: Tom Zanussi <tom.zanussi@...ux.intel.com>

On my system, /bin/sh is symlinked to dash, which doesn't understand
the >& syntax, so the kprobe and uprobe error cases fail, with this in
the log:

./ftracetest: 26: tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc:
Syntax error: Bad fd number

Changing >& to 2> does work though, and should work in any shell.

Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
---
 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 2 +-
 tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
index 281665b1348c..7eb577b1d222 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
@@ -11,7 +11,7 @@ pos=$(echo -n "${1%^*}" | wc -c) # error position
 command=$(echo "$1" | tr -d ^)
 echo "Test command: $command"
 echo > error_log
-(! echo "$command" > kprobe_events ) >& /dev/null
+(! echo "$command" > kprobe_events ) 2> /dev/null
 grep "trace_kprobe: error:" -A 3 error_log
 N=$(tail -n 1 error_log | wc -c)
 # "  Command: " and "^\n" => 13
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
index 957011300bb7..ec7389b7934b 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
@@ -11,7 +11,7 @@ pos=$(echo -n "${1%^*}" | wc -c) # error position
 command=$(echo "$1" | tr -d ^)
 echo "Test command: $command"
 echo > error_log
-(! echo "$command" > uprobe_events ) >& /dev/null
+(! echo "$command" > uprobe_events ) 2> /dev/null
 grep "trace_uprobe: error:" -A 3 error_log
 N=$(tail -n 1 error_log | wc -c)
 # "  Command: " and "^\n" => 13
-- 
2.14.1