lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 16:44:14 +0100 From: Arnd Bergmann <arnd@...db.de> To: stable@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang@...aro.org>, Chunyan Zhang <zhang.lyra@...il.com> Cc: Lanqing Liu <lanqing.liu@...eadtrum.com>, Chunyan Zhang <chunyan.zhang@...eadtrum.com>, Arnd Bergmann <arnd@...db.de>, Lanqing Liu <lanqing.liu@...soc.com>, linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [BACKPORT 4.4.y 23/25] serial: sprd: clear timeout interrupt only rather than all interrupts From: Lanqing Liu <lanqing.liu@...eadtrum.com> On Spreadtrum's serial device, nearly all of interrupts would be cleared by hardware except timeout interrupt. This patch removed the operation of clearing all interrupt in irq handler, instead added an if statement to check if the timeout interrupt is supposed to be cleared. Wrongly clearing timeout interrupt would lead to uart data stay in rx fifo, that means the driver cannot read them out anymore. Signed-off-by: Lanqing Liu <lanqing.liu@...eadtrum.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@...eadtrum.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> (cherry picked from commit 4350782570b919f254c1e083261a21c19fcaee90) Signed-off-by: Arnd Bergmann <arnd@...db.de> --- drivers/tty/serial/sprd_serial.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 176f0a2bf9d9..c894eca57e73 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -63,6 +63,7 @@ /* interrupt clear register */ #define SPRD_ICLR 0x0014 +#define SPRD_ICLR_TIMEOUT BIT(13) /* line control register */ #define SPRD_LCR 0x0018 @@ -298,7 +299,8 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id) return IRQ_NONE; } - serial_out(port, SPRD_ICLR, ~0); + if (ims & SPRD_IMSR_TIMEOUT) + serial_out(port, SPRD_ICLR, SPRD_ICLR_TIMEOUT); if (ims & (SPRD_IMSR_RX_FIFO_FULL | SPRD_IMSR_BREAK_DETECT | SPRD_IMSR_TIMEOUT)) -- 2.20.0
Powered by blists - more mailing lists