lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 17:59:17 +0200 From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> To: Tadeusz Struk <tadeusz.struk@...el.com> Cc: grawity@...il.com, James.Bottomley@...senPartnership.com, linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH RESEND v3] tpm: fix an invalid condition in tpm_common_poll On Fri, Mar 22, 2019 at 07:38:58AM -0700, Tadeusz Struk wrote: > The poll condition should only check response_length, > because reads should only be issued if there is data to read. > The response_read flag only prevents double writes. > The problem was that the write set the response_read to false, > enqued a tpm job, and returned. Then application called poll > which checked the response_read flag and returned EPOLLIN. > Then the application called read, but got nothing. > After all that the async_work kicked in. > Added also mutex_lock around the poll check to prevent > other possible race conditions. > > Cc: stable@...r.kernel.org > Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads") > Reported-by: Mantas Mikulėnas <grawity@...il.com> > Tested-by: Mantas Mikulėnas <grawity@...il.com> > Signed-off-by: Tadeusz Struk <tadeusz.struk@...el.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> Thank you. /Jarkko
Powered by blists - more mailing lists