linux-kernel - Re: [PATCH] pinctrl: intel: Implements gpio free function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d752cd9b-59f2-4524-e989-92bd0dba6b4f@metux.net>
Date:   Fri, 22 Mar 2019 19:35:42 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "zhuchangchun@...e.com" <zhuchangchun@...e.com>
Cc:     "andriy.shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "linus.walleij" <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        hendychu <hendychu@...yun.com>
Subject: Re: [PATCH] pinctrl: intel: Implements gpio free function

On 21.03.19 14:56, Mika Westerberg wrote:
> I checked it and you do this:> > +       value |= PADCFG0_GPIORXDIS;> +       value &=
~PADCFG0_GPIOTXDIS;> > which pretty much turns the pin GPIO output
unconditionally. I don't> really think it is good idea. May work in your
case but may cause> problems with others.
Uh, please don't do this. In some cases it could be even dangerous.

In general, I'd question whether such an gpio should be userland-
controlled in the first place. Better write a driver for it, which
also handles the reset properly.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287