lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 22:15:00 +0300 From: Vitaly Chikunov <vt@...linux.org> To: Mimi Zohar <zohar@...ux.ibm.com>, Dmitry Kasatkin <dmitry.kasatkin@...il.com>, linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Herbert Xu <herbert@...dor.apana.org.au>, David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org, linux-crypto@...r.kernel.org Subject: Re: [PATCH v7 11/11] integrity: support EC-RDSA signatures for asymmetric_verify Mimi, Dmitry, Can you Ack this patch? Thanks, On Fri, Mar 01, 2019 at 08:59:18PM +0300, Vitaly Chikunov wrote: > Allow to use EC-RDSA signatures for IMA by determining signature type by > the hash algorithm name. This works good for EC-RDSA since Streebog and > EC-RDSA should always be used together. > > Cc: Mimi Zohar <zohar@...ux.ibm.com> > Cc: Dmitry Kasatkin <dmitry.kasatkin@...il.com> > Cc: linux-integrity@...r.kernel.org > Signed-off-by: Vitaly Chikunov <vt@...linux.org> > --- > security/integrity/digsig_asymmetric.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c > index d775e03fbbcc..99080871eb9f 100644 > --- a/security/integrity/digsig_asymmetric.c > +++ b/security/integrity/digsig_asymmetric.c > @@ -104,9 +104,16 @@ int asymmetric_verify(struct key *keyring, const char *sig, > > memset(&pks, 0, sizeof(pks)); > > - pks.pkey_algo = "rsa"; > pks.hash_algo = hash_algo_name[hdr->hash_algo]; > - pks.encoding = "pkcs1"; > + if (hdr->hash_algo == HASH_ALGO_STREEBOG_256 || > + hdr->hash_algo == HASH_ALGO_STREEBOG_512) { > + /* EC-RDSA and Streebog should go together. */ > + pks.pkey_algo = "ecrdsa"; > + pks.encoding = "raw"; > + } else { > + pks.pkey_algo = "rsa"; > + pks.encoding = "pkcs1"; > + } > pks.digest = (u8 *)data; > pks.digest_size = datalen; > pks.s = hdr->sig; > -- > 2.11.0
Powered by blists - more mailing lists