linux-kernel - Re: New ethtool sub-feature and ethtool-netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190322073807.GL29968@unicorn.suse.cz>
Date:   Fri, 22 Mar 2019 08:38:07 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     John Linville <linville@...driver.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: New ethtool sub-feature and ethtool-netlink

On Thu, Mar 21, 2019 at 10:23:36PM +0100, Heiner Kallweit wrote:
> I have an ethtool extension in the pipe that adds one more PHY tunable
> sub-feature (for Fast Link Down support). Are smaller extensions still
> ok for ethtool,

Adding a new PHY tunable is IMHO minor change which doesn't need to wait
for the netlink interface. It's a bit more complicated due to the way
tunables (and PHY tunables) are implemented in ioctl API (which requires
both sides to have a list of tunables and their interpretation) but that
is one of the things I would like to change. :-)

After all, I don't have support for (PHY) tunables in the netlink API
yet (not even in the part which hasn't been submitted yet).

> or IOW: When do you think is ethtool-netlink going to be stable enough
> so that other developers can add features?

I would say that once it reaches mainline and userspace starts to use
it, it will have to be stable (due to "Linus' first commandment"). When
that is going to be, that depends on how the review is going, it's hard
to guess.

Michal