linux-kernel - Re: [PATCH] tty: serial_core: Spelling correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 19:56:02 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Hariprasad Kelam <hariprasad.kelam@...il.com>,
        gregkh@...uxfoundation.org, jslaby@...e.com,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial_core: Spelling correction



On 3/21/19 7:38 PM, Hariprasad Kelam wrote:
> fix warning reported by checkpatch tool
> 

It is much better if you explicitly mention what exactly you are fixing,
e.g. fix spelling mistake "overriden" -> "overridden"

It makes it easier for people to review your changes and give you
feedback.

Cultivate this practice and people will appreciate it. :)

Thanks
--
Gustavo

> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@...il.com>
> ---
>  drivers/tty/serial/serial_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 351843f..69f4871 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1514,7 +1514,7 @@ static void uart_set_termios(struct tty_struct *tty,
>  	}
>  
>  	uart_change_speed(tty, state, old_termios);
> -	/* reload cflag from termios; port driver may have overriden flags */
> +	/* reload cflag from termios; port driver may have overridden flags */
>  	cflag = tty->termios.c_cflag;
>  
>  	/* Handle transition to B0 status */
>