lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 Mar 2019 10:32:14 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Arash Fotouhi <arash@...shfotouhi.com>
Cc:     hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
        olsonse@...ch.edu, giulio.benetti@...ronovasrl.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: ni_mio_common.c: Added blank line after
 declarations

On 21/03/2019 19:18, Arash Fotouhi wrote:
> Added blank line after declarations.
> 
> Signed-off-by: Arash Fotouhi <arash@...shfotouhi.com>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 5edf59a..c6aff8f 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -2110,6 +2110,7 @@ static int ni_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
>   
>   	if (cmd->scan_begin_src == TRIG_TIMER) {
>   		unsigned int tmp = cmd->scan_begin_arg;
> +
>   		cmd->scan_begin_arg =
>   		    ni_timer_to_ns(dev, ni_ns_to_timer(dev,
>   						       cmd->scan_begin_arg,
> @@ -2120,6 +2121,7 @@ static int ni_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
>   	if (cmd->convert_src == TRIG_TIMER) {
>   		if (!devpriv->is_611x && !devpriv->is_6143) {
>   			unsigned int tmp = cmd->convert_arg;
> +
>   			cmd->convert_arg =
>   			    ni_timer_to_ns(dev, ni_ns_to_timer(dev,
>   							       cmd->convert_arg,
> 

Looks good, thanks.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

Powered by blists - more mailing lists