lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 Mar 2019 11:36:54 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     syzbot <syzbot+b70f2aabc707c69c9239@...kaller.appspotmail.com>,
        chanho.min@....com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, pavel@....cz,
        rafael.j.wysocki@...el.com, syzkaller-bugs@...glegroups.com,
        viro@...iv.linux.org.uk, Ingo Molnar <mingo@...e.hu>
Subject: Re: WARNING: syz-executor still has locks held!

On Thu 21-03-19 18:28:33, Oleg Nesterov wrote:
> On 03/20, Michal Hocko wrote:
> >
> > So we need
> > freezable_schedule_unsafe unsafe here to workaround the original problem
> > and do not trigger the warning.
> 
> Yes, but note the comment above freezable_schedule_unsafe() ;)
> 
> that is why I didn't even try to suggest to use _unsafe() instead of reverting.

Maybe I have misunderstood the discussion back then but we _knew_ that
the lock is held and considered that an acceptable compromise to
workaround the issue. And that is where the freezable_schedule_unsafe
can be used AFAIU.
 
> And to remind, until we solve the problem with cred_guard_mutex the freezer
> can fail anyway although much less likely.

Sure but this seems much less likely as the original patch seemed to
resolve the failing suspend.

So unless there is something to really handle cred_guard_mutex now, can
we get back to the workaround and silence the lockdep splat and move on
please?
-- 
Michal Hocko
SUSE Labs

Powered by blists - more mailing lists