linux-kernel - Re: [PATCH] of: use correct function prototype for of_overlay_fdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 18:37:34 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        robh+dt@...nel.org
Cc:     Hamish Martin <hamish.martin@...iedtelesis.co.nz>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: use correct function prototype for
 of_overlay_fdt_apply()

On 3/21/19 5:23 PM, Chris Packham wrote:
> When CONFIG_OF_OVERLAY is not enabled the fallback stub for
> of_overlay_fdt_apply() does not match the prototype for the case when
> CONFIG_OF_OVERLAY is enabled. Update the stub to use the correct
> function prototype.
> 
> Fixes: commit 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT")
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>  include/linux/of.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index e240992e5cb6..28797e1a9982 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -1449,7 +1449,8 @@ int of_overlay_notifier_unregister(struct notifier_block *nb);
>  
>  #else
>  
> -static inline int of_overlay_fdt_apply(void *overlay_fdt, int *ovcs_id)
> +static inline int of_overlay_fdt_apply(void *overlay_fdt, u32 overlay_fdt_size,
> +				       int *ovcs_id)
>  {
>  	return -ENOTSUPP;
>  }
> 

Thanks!

Reviewed-by: Frank Rowand <frank.rowand@...y.com>