linux-kernel - Re: [PATCH v4] perf tools: Add missing case value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190322015935.GA29608@leoy-ThinkPad-X240s>
Date:   Fri, 22 Mar 2019 09:59:41 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Solomon Tan <solomonbstoner@...tonmail.ch>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "robert.walker@....com" <robert.walker@....com>,
        "acme@...hat.com" <acme@...hat.com>
Subject: Re: [PATCH v4] perf tools: Add missing case value

Hi Solomon,

On Fri, Mar 22, 2019 at 12:47:11AM +0000, Solomon Tan wrote:

[...]

> > On my side this patch is no different from V3, i.e it doesn't pass checkpatch
> > and it doesn't apply on my next tree.
> >
> > Mathieu
> >
> > >
> >
> > pub RSA 2048/C88289A6 2018-05-09solomonbstoner@...tonmail.ch solomonbstoner@...tonmail.ch
> >
> > > sub RSA 2048/7C5E8D6D 2018-05-09
> 
> I created a new branch from `next` for the patch mentioned above. Should I
> have made the patch directly on the `next` branch instead?
> 
> I ran the following 2 commands to test the files I edited:
> ```
> perl scripts/checkpatch.pl -f tools/build/feature/test-libopencsd.c
> perl scripts/checkpatch.pl -f tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> ```
> The commands reported that the files "has no obvious style problems and is ready
> for submission." For your kind advice please. Thank you.

Suggest you to use below flow for sending patch:

- git format HEAD~1: generate patch
- ./scripts/checkpatch.pl xxxx.patch: check patch format
- git send-email xxxx.patch: use git to send patch so avoid any
  unexpected characters in the mail

P.s. Marc has a good presentation [1] for upstreaming patches, you
could check page 16 for how to use the git tool.

[1] https://elinux.org/images/2/26/Getting-Your-Patches-in-Mainline-Linux-What-Not-To-Do-and-a-Few-Things-You-Could-Try-Instead-Marc-Zyngier-ARM.pdf

Thanks,
Leo Yan