lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 11:05:53 +0800 From: Wen Yang <wen.yang99@....com.cn> To: linux-kernel@...r.kernel.org Cc: wang.yi59@....com.cn, Wen Yang <wen.yang99@....com.cn>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, Mike Rapoport <rppt@...ux.ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>, Haren Myneni <haren@...ux.vnet.ibm.com>, linuxppc-dev@...ts.ozlabs.org Subject: [PATCH 3/5] powerpc/powernv: fix possible object reference leak The call to of_find_node_by_path returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/powerpc/platforms/powernv/opal.c:741:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 733, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@....com.cn> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> Cc: Paul Mackerras <paulus@...ba.org> Cc: Michael Ellerman <mpe@...erman.id.au> Cc: Nicholas Piggin <npiggin@...il.com> Cc: Mike Rapoport <rppt@...ux.ibm.com> Cc: Andrew Morton <akpm@...ux-foundation.org> Cc: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com> Cc: Haren Myneni <haren@...ux.vnet.ibm.com> Cc: linuxppc-dev@...ts.ozlabs.org Cc: linux-kernel@...r.kernel.org --- arch/powerpc/platforms/powernv/opal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 2b0eca1..d7736a5 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -738,6 +738,7 @@ static void opal_export_attrs(void) kobj = kobject_create_and_add("exports", opal_kobj); if (!kobj) { pr_warn("kobject_create_and_add() of exports failed\n"); + of_node_put(np); return; } -- 2.9.5
Powered by blists - more mailing lists