linux-kernel - Re: [PATCH] usb: typec: tcpm: collision avoidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGZ6i=1ZyftH6CcMvpeWz9tLwJxusaOyz5BOaSS3YP2mijSQCw@mail.gmail.com>
Date:   Fri, 22 Mar 2019 19:54:06 +0800
From:   Kyle Tso <kyletso@...gle.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Badhri Jagan Sridharan <badhri@...gle.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: collision avoidance

On Fri, Mar 22, 2019 at 12:51 AM Kyle Tso <kyletso@...gle.com> wrote:
>
> On Wed, Mar 20, 2019 at 1:38 AM Guenter Roeck <linux@...ck-us.net> wrote:
> >

> > >  static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
> > >  {
> > >       if (port->port_type == TYPEC_PORT_DRP) {
> > > @@ -600,6 +664,9 @@ static void tcpm_debugfs_exit(const struct tcpm_port *port) { }
> > >
> > >  #endif
> > >
> > > +static int tcpm_ams_start(struct tcpm_port *port, enum tcpm_ams ams,
> > > +                       bool start);
> > > +
> >
> > Does this have to be a forward declaration ?
> >
> tcpm_pd_transmit() calls tcpm_ams_start() and tcpm_ams_start() calls
> tcpm_pd_transmit()
>
Since tcpm_ams_start will be divided into two parts, tcpm_pd_transmit no
longer needs to call tcpm_ams_start.

I will remove the forward declaration in the next version.

thanks,
Kyle