linux-kernel - Re: [PATCH v4 07/11] tracing: Remove trigger-extended-error-support testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Mar 2019 19:13:02 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     rostedt@...dmis.org, tglx@...utronix.de, mhiramat@...nel.org,
        namhyung@...nel.org, bigeasy@...utronix.de, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v4 07/11] tracing: Remove trigger-extended-error-support
 testcase

Hi Tom,

This should be tagged with "selftests/ftrace:". :)

Thank you,

On Fri, 22 Mar 2019 10:34:33 -0500
Tom Zanussi <zanussi@...nel.org> wrote:

> From: Tom Zanussi <tom.zanussi@...ux.intel.com>
> 
> Error handling has been moved to the common tracing/error_log, so this
> test is no longer valid.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> ---
>  .../inter-event/trigger-extended-error-support.tc  | 28 ----------------------
>  1 file changed, 28 deletions(-)
>  delete mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> deleted file mode 100644
> index 9912616a8672..000000000000
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -#!/bin/sh
> -# SPDX-License-Identifier: GPL-2.0
> -# description: event trigger - test extended error support
> -
> -
> -fail() { #msg
> -    echo $1
> -    exit_fail
> -}
> -
> -if [ ! -f set_event ]; then
> -    echo "event tracing is not supported"
> -    exit_unsupported
> -fi
> -
> -if [ ! -f synthetic_events ]; then
> -    echo "synthetic event is not supported"
> -    exit_unsupported
> -fi
> -
> -echo "Test extended error support"
> -echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/sched_wakeup/trigger
> -! echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' >> events/sched/sched_wakeup/trigger 2> /dev/null
> -if ! grep -q "ERROR:" events/sched/sched_wakeup/hist; then
> -    fail "Failed to generate extended error in histogram"
> -fi
> -
> -exit 0
> -- 
> 2.14.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>