linux-kernel - Re: [PATCH 2/3] ARM: mvebu: drop unnecessary label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YSQ.7.76.1903231354270.1971@knanqh.ubzr>
Date:   Sat, 23 Mar 2019 13:55:05 -0400 (EDT)
From:   nicolas.pitre@...aro.org
To:     Stefan Agner <stefan@...er.ch>
cc:     linux@...linux.org.uk, arnd@...db.de, ard.biesheuvel@...aro.org,
        robin.murphy@....com, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        kgene@...nel.org, krzk@...nel.org, robh@...nel.org,
        ssantosh@...nel.org, jason@...edaemon.net, andrew@...n.ch,
        gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
        tony@...mide.com, marc.w.gonzalez@...e.fr, mans@...sr.com,
        ndesaulniers@...gle.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: mvebu: drop unnecessary label

On Sat, 23 Mar 2019, Stefan Agner wrote:

> The label mvebu_boot_wa_start is not necessary and causes a build
> issue when building with LLVM's integrated assembler:
>     AS      arch/arm/mach-mvebu/pmsu_ll.o
>   arch/arm/mach-mvebu/pmsu_ll.S:59:1: error: invalid symbol redefinition
>   mvebu_boot_wa_start:
>   ^
> 
> Drop the label.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>

Acked-by: Nicolas Pitre <nico@...xnic.net>

> ---
>  arch/arm/mach-mvebu/pmsu_ll.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-mvebu/pmsu_ll.S b/arch/arm/mach-mvebu/pmsu_ll.S
> index 88651221dbdd..c1fb713e9306 100644
> --- a/arch/arm/mach-mvebu/pmsu_ll.S
> +++ b/arch/arm/mach-mvebu/pmsu_ll.S
> @@ -56,7 +56,6 @@ ENDPROC(armada_38x_cpu_resume)
>  
>  /* The following code will be executed from SRAM */
>  ENTRY(mvebu_boot_wa_start)
> -mvebu_boot_wa_start:
>  ARM_BE8(setend	be)
>  	adr	r0, 1f
>  	ldr	r0, [r0]		@ load the address of the
> -- 
> 2.21.0
> 
>