linux-kernel - Re: [PATCH] infiniband: cxgb4: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Mar 2019 16:25:58 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Steve Wise <swise@...lsio.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: cxgb4: fix a potential NULL pointer
 dereference

On 3/22/19 7:37 PM, Kangjie Lu wrote:
>> On Mar 8, 2019, at 11:19 PM, Kangjie Lu <kjlu@....edu> wrote:
>> get_skb may fail and return NULL. The fix returns "ENOMEM"
>> when it fails to avoid NULL dereference.
>>
>> Signed-off-by: Kangjie Lu <kjlu@....edu>
>> ---
>> drivers/infiniband/hw/cxgb4/cm.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
>> index 8221813219e5..502a54d57e2c 100644
>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>> @@ -1919,6 +1919,9 @@ static int send_fw_act_open_req(struct c4iw_ep *ep, unsigned int atid)
>> 	int win;
>>
>> 	skb = get_skb(NULL, sizeof(*req), GFP_KERNEL);
>> +	if (!skb)
>> +		return -ENOMEM;
>> +
> 
> Can someone review this patch? Thanks.

Hi Kangjie,

Please change the patch description to the imperative mood (see also 
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches). 
A good way to invite feedback is to add a relevant Cc-list to a patch. 
The output of scripts/get_maintainer.pl can be a good start.

Bart.