linux-kernel - RE: [PATCH v2 2/3] net: ethernet: cadence: add c45 PHY support in MDIO read/write functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Mar 2019 04:19:32 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rafal Ciepiela <rafalc@...ence.com>,
        Piotr Sroka <piotrs@...ence.com>, Jan Kotas <jank@...ence.com>
Subject: RE: [PATCH v2 2/3] net: ethernet: cadence: add c45 PHY support in
 MDIO read/write functions.

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Thursday, March 21, 2019 7:55 PM
>To: Parshuram Raju Thombare <pthombar@...ence.com>
>Cc: nicolas.ferre@...rochip.com; davem@...emloft.net;
>netdev@...r.kernel.org; f.fainelli@...il.com; hkallweit1@...il.com; linux-
>kernel@...r.kernel.org; Rafal Ciepiela <rafalc@...ence.com>; Piotr Sroka
><piotrs@...ence.com>; Jan Kotas <jank@...ence.com>
>Subject: Re: [PATCH v2 2/3] net: ethernet: cadence: add c45 PHY support in MDIO
>read/write functions.
>
>EXTERNAL MAIL
>
>
>On Mon, Mar 18, 2019 at 05:42:28PM +0000, Parshuram Thombare wrote:
>> Sorry for sending this patch again, but I didn't sent previous email
>> --in-reply-to last comment on v1 of this patch. So rectifying this
>> mistake.
>>
>> This version 2 of patch to modify MDIO read/write functions to support
>> communication with C45 PHY in Cadence ethernet controller driver.
>>
>> Changes:
>> 	1. Added timeout
>> 	2. Removed unused operation macro
>MACB_MAN_C45_POST_READ_INCR
>>
>> I thought of starting with relatively smaller, independant and simpler changes.
>> This patch is independant of patch series and looks relatively
>> straight forward with aim of supporting C45 PHY for support of high speed
>PHY's.
>
>Hi Parshuram
>
>Something i asked last time, but i'm not sure i got an answer.  Do all generations
>of the MDIO controller support C45? If the older versions only support C22, we
>need to be sure it does the right thing when asked to do a C45 transfer.

Hi Andrew,

There are some older versions of controller which doesn't support C45. I will make
sure that driver return error for C45 transfer requests when it is not supported by
controller.

>
>      Andrew

Regards,
Parshuram Thombare