linux-kernel - Re: [PATCH] mfd: mt6397: Don't call irq_dispose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190324133934.GH30105@piout.net>
Date:   Sun, 24 Mar 2019 14:39:34 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Pi-Hsun Shih <pihsun@...omium.org>
Cc:     Eddie Huang <eddie.huang@...iatek.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek RTC DRIVER" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek RTC DRIVER" 
        <linux-mediatek@...ts.infradead.org>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: mt6397: Don't call irq_dispose_mapping.

On 11/03/2019 15:55:40+0800, Pi-Hsun Shih wrote:
> The IRQ mapping was changed to not being created in the rtc-mt6397
> driver, so the irq_dispose_mapping is no longer needed.
> Also the dev_id passed to free_irq should be the same as the last
> argument passed to request_threaded_irq.
> This prevents a "Trying to free already-free IRQ 274" warning when
> unbinding the driver.
> 
> Fixes: e695d3a0b3b3 ("mfd: mt6397: Create irq mappings in mfd core driver")
> Signed-off-by: Pi-Hsun Shih <pihsun@...omium.org>
> 
> ---
>  drivers/rtc/rtc-mt6397.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com