linux-kernel - Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Mar 2019 17:34:12 +0100
From:   Cristian Sicilia <sicilia.cristian@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

On Sun, Mar 24, 2019 at 12:35:52PM +0000, Jonathan Cameron wrote:
> On Sat, 23 Mar 2019 20:21:36 +0100
> Cristian Sicilia <sicilia.cristian@...il.com> wrote:
>
> > Aligned some parameters.
> >
> > Signed-off-by: Cristian Sicilia <sicilia.cristian@...il.com>
> > ---
> >  drivers/staging/iio/adc/ad7280a.c | 36 ++++++++++++++++++------------------
> >  1 file changed, 18 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > index d9df126..55b5879 100644
> > --- a/drivers/staging/iio/adc/ad7280a.c
> > +++ b/drivers/staging/iio/adc/ad7280a.c
> > @@ -830,30 +830,30 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> >  }
> >
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > -           in_voltage-voltage_thresh_low_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_CELL_UNDERVOLTAGE);
> > +                        in_voltage - voltage_thresh_low_value,
> Firstly, that isn't in your description and secondly you just
> broke the userspace ABI.  Take a very good look at what is happening here.

Yes sorry, it will badly stringify, I fix it


>
> > +                        0644,
> > +                        ad7280_read_channel_config,
> > +                        ad7280_write_channel_config,
> > +                        AD7280A_CELL_UNDERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> > -           in_voltage-voltage_thresh_high_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_CELL_OVERVOLTAGE);
> > +                        in_voltage - voltage_thresh_high_value,
> > +                        0644,
> > +                        ad7280_read_channel_config,
> > +                        ad7280_write_channel_config,
> > +                        AD7280A_CELL_OVERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_AUX_ADC_UNDERVOLTAGE);
> > +                  0644,
> > +                  ad7280_read_channel_config,
> > +                  ad7280_write_channel_config,
> > +                  AD7280A_AUX_ADC_UNDERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_AUX_ADC_OVERVOLTAGE);
> > +                  0644,
> > +                  ad7280_read_channel_config,
> > +                  ad7280_write_channel_config,
> > +                  AD7280A_AUX_ADC_OVERVOLTAGE);
> >
> >  static struct attribute *ad7280_event_attributes[] = {
> >     &iio_dev_attr_in_thresh_low_value.dev_attr.attr,
>