linux-kernel - Re: [PATCH v5 2/2] staging: iio: ad5933: move out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e922a949de93202ac4b4c9d0548fd288efbad2c1.camel@perches.com>
Date:   Sun, 24 Mar 2019 11:01:22 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc:     lars@...afoo.de, knaack.h@....de, pmeerw@...erw.net,
        gregkh@...uxfoundation.org, michael.hennerich@...log.com,
        stefan.popa@...log.com, alexandru.Ardelean@...log.com,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH v5 2/2] staging: iio: ad5933: move out of staging

On Sun, 2019-03-24 at 16:38 +0000, Jonathan Cameron wrote:
> > diff --git a/drivers/iio/impedance-analyzer/ad5933.c b/drivers/iio/impedance-analyzer/ad5933.c

trivial note:

> > +static void ad5933_calc_out_ranges(struct ad5933_state *st)
> > +{
> > +	int i;
> > +	unsigned int normalized_3v3[4] = {1980, 198, 383, 970};

This could be static const which would make the code smaller.