linux-kernel - Re: [PATCH v2 1/2] i2c: enable buses to save their clock frequency in adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190324220913.GB6934@kunai>
Date:   Sun, 24 Mar 2019 23:09:13 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Tudor.Ambarus@...rochip.com
Cc:     Nicolas.Ferre@...rochip.com, Ludovic.Desroches@...rochip.com,
        alexandre.belloni@...tlin.com, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: enable buses to save their clock frequency
 in adapter

Hi Tudor,

thanks for your patience! Now that the at91 refactoring for the I2C
slave support is merged, we can keep going forward with your patches. As
I told you personally, I am positive in general about this change.

> +	u32 bus_freq_hz;

Why not unsigned int?

I also think we should have accessor functions for this new member. They
will be very simple currently because we don't really support changing
the bus frequency at runtime. However, I can see that it could be added
somewhen on top of this change, and then we need to extend the accessor
functions with some locking.

For now, I think this can be solved with simple policy: The value has to
be set before calling i2c_add_adapter(). Also, we should define that '0'
means 'value not set'.

So far about my thoughts. Any more comments from the list are welcome!

Thanks,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)