linux-kernel - Re: [PATCH 3/3] net: ethernet: ti: fix possible object reference leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190323.212202.1802065146621678109.davem@davemloft.net>
Date:   Sat, 23 Mar 2019 21:22:02 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     wen.yang99@....com.cn
Cc:     linux-kernel@...r.kernel.org, wang.yi59@....com.cn, w-kwok2@...com,
        m-karicheri2@...com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] net: ethernet: ti: fix possible object reference
 leak

From: Wen Yang <wen.yang99@....com.cn>
Date: Fri, 22 Mar 2019 11:04:09 +0800

> The call to of_get_child_by_name returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> 
> Detected by coccinelle with the following warnings:
> ./drivers/net/ethernet/ti/netcp_ethss.c:3661:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
> ./drivers/net/ethernet/ti/netcp_ethss.c:3665:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3654, but without a corresponding object release within this function.
> 
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>

Applied.