linux-kernel - Re: [PATCH] PCI: al: add pcie-al.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190325173646.GR251185@google.com>
Date:   Mon, 25 Mar 2019 12:36:47 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jonathan Chocron <jonnyc@...zon.com>
Cc:     linux-pci@...r.kernel.org, lorenzo.pieralisi@....com,
        linux-kernel@...r.kernel.org, vaerov@...zon.com, dwmw@...zon.co.uk,
        benh@...nel.crashing.org, alisaidi@...zon.com, zeev@...zon.com,
        ronenk@...zon.com, barakw@...zon.com,
        Talel Shenhar <talel@...zon.com>
Subject: Re: [PATCH] PCI: al: add pcie-al.c

On Mon, Mar 25, 2019 at 05:56:35PM +0200, Jonathan Chocron wrote:
> On 3/25/19 14:58, Bjorn Helgaas wrote:

> > I think you're actually looking for a AMZN0001 device, not a PNP0C02
> > device.  Your firmware might have a PNP0C02 _HID and AMZN0001 _CID, but
> > that's not relevant here since you're only filtering by AMZN0001.
> > 
> Actually, the _HID is AMZN0001 and the _CID is PNP0C02, so that's why
> I used PNP0C02 (to state that it is of this "type"). Please let me know if
> you still think it should be changed, so I'll integrate it into v2.

I do still think it should be changed, because there's nothing in the
code that refers to PNP0C02.  That _CID could be absent or could
contain any other ID and it wouldn't make any difference to the
driver.  But if there's no device with _HID or _CID of AMZN0001, the
driver will fail.

Bjorn