linux-kernel - Re: [PATCH v3 1/2] dmaengine: tegra210-adma: use devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190325045429.GF5348@vkoul-mobl>
Date:   Mon, 25 Mar 2019 10:24:29 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     dan.j.williams@...el.com, treding@...dia.com, jonathanh@...dia.com,
        dmaengine@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dmaengine: tegra210-adma: use devm_clk_*() helpers

On 13-03-19, 17:02, Sameer Pujar wrote:
> adma driver is using pm_clk_*() interface for managing clock resources.
> With this it is observed that clocks remain ON always. This happens on
> Tegra devices which use BPMP co-processor to manage clock resources,
> where clocks are enabled during prepare phase. This is necessary because
> clocks to BPMP are always blocking. When pm_clk_*() interface is used on
> such Tegra devices, clock prepare count is not balanced till remove call
> happens for the driver and hence clocks are seen ON always. Thus this
> patch replaces pm_clk_*() with devm_clk_*() framework.

Both applied, thanks

-- 
~Vinod