linux-kernel - Re: [PATCH 3/6] mfd: da9063: remove platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190325202203.GA7749@kunai>
Date:   Mon, 25 Mar 2019 21:22:03 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Simon Horman <horms@...ge.net.au>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH 3/6] mfd: da9063: remove platform_data support


> > -	if (pdata) {
> > -		da9063->flags = pdata->flags;
> > -		da9063->irq_base = pdata->irq_base;
> > -	} else {
> > -		da9063->flags = 0;
> > -		da9063->irq_base = -1;
> > -	}
> > +	da9063->flags = 0;
> > +	da9063->irq_base = -1;
> 
> If the flag and irq_base fields have fixed values can
> they be removed? As a follow-up?

There is likely more simplification possible. But yes, it should be a
follow up patch, I think.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)