linux-kernel - Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVatmNo8QyQbd4yxCucV0QkGiVbeVmjH=quAX9MH++53md6fA@mail.gmail.com>
Date:   Mon, 25 Mar 2019 20:29:07 +0000
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy:
 use new parport device model

Hi Greg, Linus,

On Mon, Mar 25, 2019 at 8:12 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Mon, Mar 25, 2019 at 11:04:49AM -0700, Linus Torvalds wrote:
> > On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> > >
> > > I bisected it down to this commit:
> > >
> > >   aec4211204d ("parport: daisy: use new parport device model")
> >
> > I was confused, because no such commit exists.
> >
> > But it turns out you have the right commit ID in your subject line,
> > and you just dropped the initial '1' .
> >
> > Anyway, that commit does look odd - why is the daisy_drv_init() done
> > by parport_bus_init() rather than just as a regular module init? And
> > as a result, now when daisy_drv_init() blocks, that blocks
> > parport_bus_init(). I dunno. It seems to not really have a good reason
> > for it.
> >
> > I think it should just be reverted unless Sudip can come up with a
> > trivial fix. Greg?
>
> I recommend just reverting it for now.  The parport is "odd" in how it
> has had to be converted over time to the driver model, which is why I
> thought this patch was ok.  Looks like it wasn't, sorry.

It was reported by Michal from Suse and has now been fixed and he has
tested and confirmed it is working.
It is only happening on those systems/distro who has an alias set for
"parport_lowlevel".
Will send out the patch shortly.

-- 
Regards
Sudip