linux-kernel - Re: [PATCH] dma:xgene-dma:move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190325055223.GL5348@vkoul-mobl>
Date:   Mon, 25 Mar 2019 11:22:23 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Jeff Xie <chongguiguzi@...il.com>
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma:xgene-dma:move spin_lock_bh to spin_lock in tasklet

On 20-03-19, 00:45, Jeff Xie wrote:
> It is unnecessary to call spin_lock_bh in a tasklet.

1. Please use the right subsystem name, dmaengine: xxx (you cna find
that by git log on that subsystem)

2. Space after each :, like dmaengine: xgene-dma: move...

3. Please explain a bit more about the change on why it is unnecessary
:)

Nevertheless, I have fixed 1 & 2 above and applied it

-- 
~Vinod