lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 25 Mar 2019 13:57:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs404-evb: Enable uart3 and add
 Bluetooth

On 04-03-19, 23:08, Bjorn Andersson wrote:
> Enable blsp1_uart3, define its pinconf and add the bluetooth node.
> 
> It seems provisioning is lacking a valid BD address, preventing the
> interface from initializing, so provide a dummy for now.

This looks good though I need to hand edit the patch order a bit when
applied on top of the series I sent..

Reviewed-by: Vinod Koul <vkoul@...nel.org>
Tested-by: Vinod Koul <vkoul@...nel.org>


> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 45 ++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 536f735243d2..5c502e6db424 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -7,6 +7,7 @@
>  / {
>  	aliases {
>  		serial0 = &blsp1_uart2;
> +		serial1 = &blsp1_uart3;
>  	};
>  
>  	chosen {
> @@ -19,6 +20,32 @@
>  		regulator-always-on;
>  		regulator-boot-on;
>  	};
> +
> +	vdd_ch0_3p3:
> +	vdd_esmps3_3p3: vdd-esmps3-3p3-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "eSMPS3_3P3";
> +
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +	};
> +};
> +
> +&blsp1_uart3 {
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "qcom,wcn3990-bt";
> +		vddio-supply = <&vreg_l6_1p8>;
> +		vddxo-supply = <&vreg_l5_1p8>;
> +		vddrf-supply = <&vreg_l1_1p3>;
> +		vddch0-supply = <&vdd_ch0_3p3>;
> +
> +		local-bd-address = [ 02 00 00 00 5a ad ];
> +
> +		max-speed = <3200000>;
> +	};
>  };
>  
>  &remoteproc_adsp {
> @@ -205,3 +232,21 @@
>  		bias-disable;
>  	};
>  };
> +
> +&blsp1_uart3_default {
> +	cts {
> +		pins = "gpio84";
> +		bias-disable;
> +	};
> +
> +	rts-tx {
> +		pins = "gpio85", "gpio82";
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +
> +	rx {
> +		pins = "gpio83";
> +		bias-pull-up;
> +	};
> +};
> -- 
> 2.18.0

-- 
~Vinod

Powered by blists - more mailing lists