linux-kernel - RE: [RFC PATCH 3/3] arch/x86/acrn: add hypercall for acrn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 09:30:46 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Zhao, Yakui" <yakui.zhao@...el.com>
cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "Chen, Jason CJ" <jason.cj.chen@...el.com>
Subject: RE: [RFC PATCH 3/3] arch/x86/acrn: add hypercall for
 acrn_hypervisor

On Mon, 25 Mar 2019, Zhao, Yakui wrote:
> 
> >-----Original Message-----
> >From: Thomas Gleixner [mailto:tglx@...utronix.de]
> >Sent: Saturday, March 23, 2019 12:02 AM
> >To: Zhao, Yakui <yakui.zhao@...el.com>
> >Cc: linux-kernel@...r.kernel.org; x86@...nel.org; Chen, Jason CJ
> ><jason.cj.chen@...el.com>
> >Subject: Re: [RFC PATCH 3/3] arch/x86/acrn: add hypercall for acrn_hypervisor


Can you please fix your mail client not to copy the full email headers on
the reply?

The simple: On $DATE, someone wrote: like the below is sufficient.

> >> +static inline long acrn_hypercall0(unsigned long hcall_id) {
> >> +
> >> +	/* x86-64 System V ABI register usage */
> >
> >Well, yes. But can you please provide a link to the hypercall specification in the
> >changelog?
> >
> >Also instead of repeating the same comment over and over, explain the calling
> >convention in a top level comment.
> 
> This is the low-level implementation of low-level hypercall. It is similar to 
> Kvm_hypercall1/2/3 in arch/x86/include/asm/kvm_para.h.
> Does it make sense that the below comments are added before acrn_hypercall0/1/2?
> /*
>  * Hypercalls for ACRN Guest
>  * 
>  * Hypercall number is passed in r8 register.
>  * Return value will be placed in rax. 
>  * Up to 2 arguments are passed in rdi, rsi.
>  */   

Yes, that's much more helpful.

Thanks,

	tglx