linux-kernel - Re: [PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 10:15:50 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Phil Elwell <phil@...pberrypi.org>,
        linux-kernel@...r.kernel.org,
        Tobias Büttner <tobias.buettner@....de>,
        Eric Anholt <eric@...olt.net>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-rpi-kernel@...ts.infradead.org, pakki001@....edu,
        Dominic Braun <inf.braun@....de>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

Hi Kangjie,

Am 24.03.19 um 23:43 schrieb Kangjie Lu:
> When kzalloc fails, "platform_state->inited = 1" is a NULL pointer
> dereference. The fix returns VCHIQ_ERROR in case it failed to
> avoid NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@....edu>
please add a proper fixes tag.
> ---
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c  | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index dd4898861b83..0f12fe617575 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -209,6 +209,8 @@ vchiq_platform_init_state(struct vchiq_state *state)
>  	struct vchiq_2835_state *platform_state;
>  
>  	state->platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL);
> +	if (!state->platform_state)
> +		return VCHIQ_ERROR;

this change is good, but vchiq_init_state doesn't bail out immediately
in case vchiq_platform_init_state fails.

Could you please fix that, too?

Thanks Stefan

>  	platform_state = (struct vchiq_2835_state *)state->platform_state;
>  
>  	platform_state->inited = 1;