linux-kernel - Re: [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a26586d-803b-5fad-e611-449bdb49096e@huawei.com>
Date:   Mon, 25 Mar 2019 09:48:42 +0000
From:   John Garry <john.garry@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Borislav Petkov <bp@...e.de>,
        Guenter Roeck <linux@...ck-us.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        <linux-pci@...r.kernel.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Linuxarm <linuxarm@...wei.com>, Alexander Graf <agraf@...e.de>
Subject: Re: [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex

On 23/03/2019 19:12, Andy Shevchenko wrote:
> On Wed, Mar 20, 2019 at 8:14 PM John Garry <john.garry@...wei.com> wrote:
>>
>> Some prints in the code are for a hex number, but don't prefix "0x". Add
>> the prefix, as is the norm.
>
>> -       pr_err("addr %llx not registered in io_range_list\n",
>> +       pr_err("addr 0x%llx not registered in io_range_list\n",
>>                (unsigned long long) addr);
>
> Can we use %pa at the same time?
>

Hi Andy,

OK, I think that we can use %pa and drop the casting to unsigned long long.

Thanks for checking,
John