linux-kernel - Re: regression (bisected): "modprobe parport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 10:00:54 +0000
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

On Mon, Mar 25, 2019 at 7:30 AM Michal Kubecek <mkubecek@...e.cz> wrote:
>
> On Sun, Mar 24, 2019 at 07:38:38PM +0000, Sudip Mukherjee wrote:
> > And I was able to reproduce the problem using a vm and Suse Tumblewood with
> > next-20190322. Can you please try the attached patch and test on your vm and
> > machine and check if it fixes the problem.
> >
> > --
> > Regards
> > Sudip
>
> > diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> > index 0171b8dbcdcd..f87948fbfc34 100644
> > --- a/drivers/parport/share.c
> > +++ b/drivers/parport/share.c
> > @@ -274,7 +274,7 @@ static int port_check(struct device *dev, void *dev_drv)
> >  int __parport_register_driver(struct parport_driver *drv, struct module *owner,
> >                             const char *mod_name)
> >  {
> > -     if (list_empty(&portlist))
> > +     if (list_empty(&portlist) && strcmp(drv->name, "daisy_drv"))
> >               get_lowlevel_driver();
> >
> >       if (drv->devmodel) {
>
> Yes, with this patch (on top of v5.1-rc2), both physical machine and VM
> let the module(s) load cleanly even with the alias line restored.
>
> Tested-by: Michal Kubecek <mkubecek@...e.cz>

Thanks Michal. I will add it to my queue with your Tested-by.

btw, I think I liked using Suse. :)


-- 
Regards
Sudip