linux-kernel - Re: [PATCH v2] dccp: Fix memleak in __feat_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f86a5326-2681-1d8f-094a-4316837f7beb@huawei.com>
Date:   Mon, 25 Mar 2019 10:51:14 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <gerrit@....abdn.ac.uk>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <dccp@...r.kernel.org>
Subject: Re: [PATCH v2] dccp: Fix memleak in __feat_register_sp


On 2019/3/25 8:12, David Miller wrote:
> From: Yue Haibing <yuehaibing@...wei.com>
> Date: Fri, 22 Mar 2019 21:43:48 +0800
> 
>> From: YueHaibing <yuehaibing@...wei.com>
>>
>> If dccp_feat_push_change fails, we forget free the mem
>> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>> v2: kfree 'val --> 'fval'
> 
> Don't submit any patches for at least 2 days, I am getting really tired of
> changes you don't even COMPILE TEST:
> 
>   CC [M]  net/dccp/feat.o
> net/dccp/feat.c: In function ‘__feat_register_sp’:
> net/dccp/feat.c:742:13: error: invalid type argument of ‘->’ (have ‘dccp_feat_val’ {aka ‘union <anonymous>’})
>    kfree(fval->sp.vec);
>       

I'm very sorry for this, will self-reflection.

       ^~
>