linux-kernel - Re: [PATCH v4 1/2] Bluetooth: hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e17eb2d2-8d32-70c6-32f9-435671233bfc@free.fr>
Date:   Mon, 25 Mar 2019 12:49:48 +0100
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Harish Bandi <c-hbandi@...eaurora.org>
Cc:     MSM <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH v4 1/2] Bluetooth: hci_qca: Added support for WCN3998

On 25/03/2019 12:31, Harish Bandi wrote:

> +bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
> +{
> +	if ((soc_type  == QCA_WCN3990) || (soc_type  == QCA_WCN3998))
                      ^                             ^
            spurious white-space               here as well

> +		return true;
> +
> +	return false;
> +}

(Apologies for the bike-shed)

I don't know what the kernel coding-style says about this, but for
functions returning bool, isn't it better to write

	return $BOOLEAN_EXPRESSION;

instead of

	if ($BOOLEAN_EXPRESSION)
		return true;
	return false;

i.e.

bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
{
	return soc_type == QCA_WCN3990 || soc_type  == QCA_WCN3998;
}

Regards.