linux-kernel - Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhSdy0+9rgJtxjhrYAEt1Tem79ixL7sSKUHp63Hf-5sb+31+Q@mail.gmail.com>
Date:   Mon, 25 Mar 2019 08:51:31 +0530
From:   Anup Patel <anup@...infault.org>
To:     Gary Guo <gary@...yguo.net>
Cc:     Anup Patel <Anup.Patel@....com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Christoph Hellwig <hch@...radead.org>,
        Atish Patra <Atish.Patra@....com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

On Mon, Mar 25, 2019 at 12:44 AM Gary Guo <gary@...yguo.net> wrote:
>
>
>
> > -----Original Message-----
> > From: linux-riscv <linux-riscv-bounces@...ts.infradead.org> On Behalf Of Anup
> > Patel
> > Sent: Sunday, March 24, 2019 11:08
> > To: Palmer Dabbelt <palmer@...ive.com>; Albert Ou <aou@...s.berkeley.edu>
> > Cc: Anup Patel <Anup.Patel@....com>; linux-kernel@...r.kernel.org; Mike
> > Rapoport <rppt@...ux.ibm.com>; Christoph Hellwig <hch@...radead.org>; Atish
> > Patra <Atish.Patra@....com>; Paul Walmsley <paul.walmsley@...ive.com>;
> > linux-riscv@...ts.infradead.org; Christoph Hellwig <hch@....de>
> > Subject: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany
> >
> > diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile
> > index eb22ab49b3e0..7307609d405b 100644
> > --- a/arch/riscv/mm/Makefile
> > +++ b/arch/riscv/mm/Makefile
> > @@ -3,3 +3,5 @@ obj-y += fault.o
> >  obj-y += extable.o
> >  obj-y += ioremap.o
> >  obj-y += cacheflush.o
> > +
> > +CFLAGS_init.o := -mcmodel=medany
>
> I think you should also remove CFLAGS_setup.o from kernel/Makefile, as I think it was there solely for the correctness of setup_vm. As setup_vm is now in mm/init.o, the old CFLAGS probably isn't needed and should be removed in the same patch. Disclaimer: I haven't tested it.

Sure, I will remove it in v2 patch. Thanks for catching.

Regards,
Anup