linux-kernel - Re: [PATCH] mmc: usdhi6rol0: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoJPZBWZk+htuuvDyAYRVMML=tOMrij5P1v02XGm2DU3Q@mail.gmail.com>
Date:   Mon, 25 Mar 2019 14:26:35 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] mmc: usdhi6rol0: mark expected switch fall-throughs

[...]

> >> @@ -1688,6 +1688,7 @@ static void usdhi6_timeout_work(struct work_struct *work)
> >>         default:
> >>                 dev_err(mmc_dev(host->mmc), "Invalid state %u\n", host->wait);
> >>                 /* mrq can be NULL in this actually impossible case */
> >> +               /* fall through */
> >
> > Please make this one comment.
> >
> >>         case USDHI6_WAIT_FOR_CMD:
> >>                 usdhi6_error_code(host);
> >>                 if (mrq)
> >> @@ -1713,6 +1714,7 @@ static void usdhi6_timeout_work(struct work_struct *work)
> >>                  * If USDHI6_WAIT_FOR_DATA_END times out, we have already unmapped
> >>                  * the page
> >>                  */
> >> +               /* fall through */
> >
> > Ditto.
> >
>
> OK.  The reason why I didn't do that is because the line would exceed the 80 characters
> in both cases. But I'll respin if you are OK with that.
>

What's wrong with having several lines per comment-section?

Kind regards
Uffe