linux-kernel - Re: [PATCH v2] usb: sierra: fix a missing check of device_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1903251013140.1485-100000@iolanthe.rowland.org>
Date:   Mon, 25 Mar 2019 10:15:15 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Kangjie Lu <kjlu@....edu>
cc:     pakki001@....edu, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>,
        <usb-storage@...ts.one-eyed-alien.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: sierra: fix a missing check of device_create_file

On Sun, 24 Mar 2019, Kangjie Lu wrote:

> device_create_file() could fail and return an error code. The fix
> captures the error and returns the error code upstream in case it
> indeed failed.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>  drivers/usb/storage/sierra_ms.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
> index 6ac60abd2e15..e605cbc3d8bf 100644
> --- a/drivers/usb/storage/sierra_ms.c
> +++ b/drivers/usb/storage/sierra_ms.c
> @@ -194,8 +194,6 @@ int sierra_ms_init(struct us_data *us)
>  		kfree(swocInfo);
>  	}
>  complete:
> -	result = device_create_file(&us->pusb_intf->dev, &dev_attr_truinst);
> -
> -	return 0;
> +	return device_create_file(&us->pusb_intf->dev, &dev_attr_truinst);
>  }

Acked-by: Alan Stern <stern@...land.harvard.edu>

It's possible the original author intended the function to succeed even 
if device_create_file() failed, since the information in the file 
doesn't seem to be very important.  However, I will accept the patch.

Alan Stern