linux-kernel - Re: [PATCH v17] i2c: Add drivers for the AMD PCIe MP2 I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190325143752.GA4456@kunai>
Date:   Mon, 25 Mar 2019 15:37:52 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Elie Morisse <syniurge@...il.com>
Cc:     linux-i2c@...r.kernel.org, Nehal-bakulchandra.Shah@....com,
        Shyam-sundar.S-k@....com, sandeep.singh@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v17] i2c: Add drivers for the AMD PCIe MP2 I2C controller

On Tue, Mar 05, 2019 at 12:13:19PM -0300, Elie Morisse wrote:
> MP2 controllers have two separate busses, so may accommodate up to two I2C
> adapters. Those adapters are listed in the ACPI namespace with the
> "AMDI0011" HID, and probed by a platform driver.
> 
> Communication with the MP2 takes place through MMIO registers, or through
> DMA for more than 32 bytes transfers.
> 
> This is major rework of the patch submitted by Nehal-bakulchandra Shah from
> AMD (https://patchwork.kernel.org/patch/10597369/).
> 
> Most of the event handling of v3 was rewritten to make it work with more
> than one bus (e.g on Ryzen-based Lenovo Yoga 530), and this version
> contains many other improvements.
> 
> Signed-off-by: Elie Morisse <syniurge@...il.com>

OK, there are still some parts I am not exactly happy with (e.g. the
find/match_device mechanism), but the driver seems to work and I don't
see major blockers anymore. The remaining issues can be fixed
incrementally. Hopefully the driver will become more visible now.

Applied to for-next, thanks everyone, especially Elie!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)