linux-kernel - Re: [PATCH v2 1/1] iommu: Bind process address spaces to devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190325144241.GC25350@8bytes.org>
Date:   Mon, 25 Mar 2019 15:44:13 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Jean-Philippe Brucker <jean-philippe.brucker@....com>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        christian.koenig@....com, kevin.tian@...el.com,
        jacob.jun.pan@...ux.intel.com, ashok.raj@...el.com,
        baolu.lu@...ux.intel.com, alex.williamson@...hat.com,
        zhangfei.gao@...mail.com
Subject: Re: [PATCH v2 1/1] iommu: Bind process address spaces to devices

Hey Jean-Philippe,

thanks for the patch, I think we are on the finish line with this
interface. Just one small question below.

On Wed, Mar 20, 2019 at 03:02:58PM +0000, Jean-Philippe Brucker wrote:
> +int iommu_sva_set_ops(struct iommu_sva *handle,
> +		      const struct iommu_sva_ops *sva_ops)
> +{
> +	const struct iommu_ops *ops = handle->dev->bus->iommu_ops;
> +
> +	if (!ops || !ops->sva_set_ops)
> +		return -ENODEV;
> +
> +	return ops->sva_set_ops(handle, sva_ops);
> +}

What is the purpose of the sva_set_ops call-back in iommu-ops? Is the
IOMMU driver supposed to do some extra setup work with the provided ops?
Otherwise we can just store the pointer in 'struct iommu_sva' without
calling into the iommu driver.


Regards,

	Joerg